Skip to content

RFC: Allow REST transport for PubSub Java client. #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RFC: Allow REST transport for PubSub Java client. #2075

wants to merge 1 commit into from

Conversation

sanjivr
Copy link

@sanjivr sanjivr commented Jun 13, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Supports #2074

This leverages capabilities added in #1162

We're looking for input on whether

  • this approach is feasible or not
  • the SDK might consider making this generally available after the approach has been ratified and unit tests are included.

@sanjivr sanjivr requested a review from a team as a code owner June 13, 2024 16:55
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Jun 13, 2024
@sanjivr sanjivr mentioned this pull request Jun 13, 2024
Open
sanjivr
sanjivr commented Jun 13, 2024
View reviewed changes
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
this.publishContextWithCompression =
GrpcCallContext.createDefault()
.withCallOptions(CallOptions.DEFAULT.withCompression(GZIP_COMPRESSION));
this.enableRESTJsonTransport
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: If the user attempts to enable compression on the JSON transport, should the SDK throw an exception or silently ignore the same as the HttpJsonCallContext does not support compression ?

@sjvanrossum sjvanrossum mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelpri10 michaelpri10

Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanjivr @michaelpri10